Batch Programm Beta Test

[mokus]

Hi,
ich habe mal seit Anfang der Woche ein Batch Programm programmiert und wollte jetzt mal fragen ob wer Lust hat es zu testen. Ausserdem könntet ihr mir vieleicht auch ein paar Tipps geben zum verbessern.

->Download <-

[mokus]

Habe noch ein Fehler gefunden beim bennen der Dateien und korrigiert.

Bevor ich was sauge zeig mal den code....

[mokus]

  // Variablen
  
  Dim i As Integer = 0
  Dim x As Integer = 0
  Dim z As  Integer = 0
  Dim y As  Integer = 1
  
  Dim countA As Integer = 0
  Dim countB As Integer = 0
  Dim countC As Integer = 0
  
  Dim fileid As Integer = 0
  
  Dim filelistA as String
  
  Dim filenameA As String
  Dim filenameB As String
  Dim filenameC As String
  
  Dim d As Date
  Dim s As String
  Dim t As String
  
  dim file As FolderItem
  
  Dim currentFolder as FolderItem
  
  if start = 1 Then
    fenster_1.filelist.DeleteAllRows
  End If
  
  currentFolder = GetFolderItem(folder)
  
  filelistA = currentFolder.Item(1).Name
  for i = 2 to currentFolder.Count
    if currentFolder.Item(i).Name = "." Then
    Else
      if currentFolder.Item(i).Directory then
        // Ausführung bei Ordner
      Else
        If "Thumbs.db" = currentFolder.Item(i).Name and fenster_1.einstellung_1.Value = True Then
        Else
          filelistA = filelistA +  ";" + currentFolder.Item(i).Name
        End If
      End If
    End If
  Next
  
  // Anzahl der Dateien im Ordner
  countC = CountFields(filelistA, ".")
  
  
  
  // EIngabfelder einstellung
  fenster_1.filename_1.Enabled = False
  fenster_1.save_art_1.Enabled = False
  fenster_1.save_art_2.Enabled = False
  fenster_1.save_art_3.Enabled = False
  
  fenster_1.einstellung_1.Enabled = False
  fenster_1.einstellung_2.Enabled = False
  
  fenster_1.button_1.Enabled = False
  
  // Lade balken
  fenster_1.load_1.Maximum = countC
  fenster_1.load_1.Value = 0
  
  
  z = 0
  For i = 1 to countC-1
    fileid =  i
    fenster_1.load_1.Value = fileid
    
    // Ausführung bei Datei
    
    
    
    filenameA = GetFolderItem(filelistA.NthField(";",y)).Name
    
    // Überprüfung ob Vorhandener Dateiename benutzt wird
    if fenster_1.filename_1.Text = "" Then
    Else
      filenameA = fenster_1.filename_1.Text + "." + filenameA.NthField(".",CountFields(filenameA, "."))
    End If
    
    z = z + 1
    save_art(z)
    
    If filename_sequence = 1 Then
      // 1_Datei.txt
      
      // Dateinamen erstellen
      filenameB = filenameA.NthField(".",0)
      countA = CountFields(filenameA, ".")
      
      filenameB = filename_art + filenameA
      
    ElseIf filename_sequence = 2 Then
      // Datei_1.txt
      
      // Dateinamen erstellen
      filenameB = filenameA.NthField(".",0)
      countA = CountFields(filenameA, ".")
      
      for x = 1 to (countA - 1)
        filenameB = filenameB + filenameA.NthField(".",x)
        
        if (countA - 1) = x then
        else
          filenameB = filenameB + "."
        end if
      next
      filenameB = filenameB + filename_art + "." + filenameA.NthField(".",CountFields(filenameA, "."))
    End If
    
    
    fenster_1.filelist.AddRow GetFolderItem(filelistA.NthField(";",y)).Name
    
    fenster_1.filelist.Cell(z-1,1) = "=>"
    
    fenster_1.filelist.Cell(z-1,2) = filenameB
    
    
    GetFolderItem(folder + "/" + filelistA.NthField(";",y)).Name  = folder + "/" + filenameB
    
    fenster_1.filelist.Selected(z-1)= True
    s = s + fenster_1.filelist.Cell(z-1,0) + fenster_1.filelist.Cell(z-1,1) + fenster_1.filelist.Cell(z-1,2) + chr(13)
    fenster_1.filelist.Selected(z-1)= False
    
    y = y + 1
    
  Next
  
  If fenster_1.einstellung_2.Value = True Then
    // Datei erstellen
    t = "Logfile - Files: " + str(y-1) + Chr(13) + s
    addfile("Batch_log.log",ReplaceLineEndings(t, EndOfLine.Windows))
  End If
  
  Beep
  start = 1
  files = countC
  MsgBox "Batch finished | " + str(y-1) + " Files"
  
  // Eingabefelder einstellung
  fenster_1.filename_1.Enabled = True
  fenster_1.save_art_1.Enabled = True
  fenster_1.save_art_2.Enabled = True
  fenster_1.save_art_3.Enabled = True
  
  fenster_1.einstellung_1.Enabled = True
  fenster_1.einstellung_2.Enabled = True
  
  fenster_1.button_1.Enabled = True
  
  // Ladebalken
  fenster_1.load_1.Maximum = 100
  fenster_1.load_1.Value = 0